ereuse
/
devicehub-django
8
0
Fork 0
Code Issues 5 Pull Requests 2 Packages Projects Releases Wiki Activity

up_snapshots: simplify and clarify errors 

specially, do not halt in case of errors, just print them in logs
This commit is contained in:
pedro 2024-11-12 14:37:55 +01:00
parent fc849f0360
commit 57f9e28466
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
evidence/management/commands/up_snapshots.py
View File

@ -54,23 +54,15 @@ class Command(BaseCommand):
self.snapshots.append((content, path_name)) self.snapshots.append((content, path_name))
except json.JSONDecodeError as e:
logger.error("JSON decode error in file %s: %s", filepath, e)
raise ValueError(f"Invalid JSON format in file. Check for file integrity.") from e
except FileNotFoundError as e:
logger.error("File not found: %s", filepath)
raise FileNotFoundError(f"File not found") from e
#or we cath'em all
except Exception as e: except Exception as e:
logger.exception("Unexpected error when opening file %s: %s", filepath, e) logger.error("Could not open file %s: %s", filepath, e)
raise Exception(f"Unexpected error when opening file") from e
def parsing(self): def parsing(self):
for s, p in self.snapshots: for s, p in self.snapshots:
try: try:
self.devices.append(Build(s, self.user)) self.devices.append(Build(s, self.user))
move_json(p, self.user.institution.name) move_json(p, self.user.institution.name)
except Exception as err: except Exception as e:
snapshot_id = s.get("uuid", "") snapshot_id = s.get("uuid", "")
txt = "Could not parse snapshot: %s" txt = "Could not parse snapshot %s: %s"
logger.error(txt, snapshot_id) logger.error(txt, snapshot_id, e)