ereuse
/
devicehub-django
8
0
Fork 0
Code Issues 5 Pull Requests 2 Packages Projects Releases Wiki Activity

better error messages

This commit is contained in:
Thomas Nahuel Rusiecki 2024-11-11 04:06:22 -03:00
parent a0a22e7840
commit b752a8750e
2 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
evidence/forms.py
View File

@ -33,13 +33,21 @@ class UploadForm(forms.Form):
exist_annotation = Annotation.objects.filter( exist_annotation = Annotation.objects.filter(
uuid=file_json['uuid'] uuid=file_json['uuid']
).first() ).first()
if exist_annotation: if exist_annotation:
raise ValidationError("error: {} exist".format(file_name)) raise ValidationError(
_("The snapshot already exists"),
except Exception: code="duplicate_snapshot",
raise ValidationError("error in: {}".format(file_name)) params={"file_name": file_name},
)
#Caught any error and display it as Validation Error so the Form handles it
except Exception as e:
raise ValidationError(
_("Error on '%(file_name)s': %(error)s"),
code="error",
params={"file_name": file_name, "error": getattr(e, 'message', str(e))},
)
self.evidences.append((file_name, file_json)) self.evidences.append((file_name, file_json))
return True return True

6
evidence/management/commands/up_snapshots.py
View File

@ -56,14 +56,14 @@ class Command(BaseCommand):
except json.JSONDecodeError as e: except json.JSONDecodeError as e:
logger.error("JSON decode error in file %s: %s", filepath, e) logger.error("JSON decode error in file %s: %s", filepath, e)
raise ValueError(f"Invalid JSON format in file {filepath}") from e raise ValueError(f"Invalid JSON format in file. Check for file integrity.") from e
except FileNotFoundError as e: except FileNotFoundError as e:
logger.error("File not found: %s", filepath) logger.error("File not found: %s", filepath)
raise FileNotFoundError(f"File not found: {filepath}") from e raise FileNotFoundError(f"File not found") from e
#or we cath'em all #or we cath'em all
except Exception as e: except Exception as e:
logger.exception("Unexpected error when opening file %s: %s", filepath, e) logger.exception("Unexpected error when opening file %s: %s", filepath, e)
raise Exception(f"Unexpected error when opening file {filepath}") from e raise Exception(f"Unexpected error when opening file") from e
def parsing(self): def parsing(self):
for s, p in self.snapshots: for s, p in self.snapshots: