ereuse/devicehub-django
9
0
Fork 0
Code Issues 6 Pull requests 12 Packages Projects Releases Wiki Activity

Mini pull request que arregla inconsistencia entre .env.example y settings.py respecto a la variable DOMAIN #58

Open
sergiogimenez wants to merge 2 commits from hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file into main
pull from: hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
merge into: ereuse:main
Conversation 0 Commits 2 Files changed 2 +7 -11
sergiogimenez commented 2025-02-25 09:02:03 +00:00
Owner
Copy link

Pequeño pull request que facilita la vida al usuario que despliega devicehub. .env.example contiene DEVICEHUB_DOMAIN, pero settings.py espera que haya DOMAIN. Si el usuario se copia .env.examplea .envcomo se suele hacer, se queja porque DOMAIN no está definido.

En mi opinión es más conveniente como lo deja este pull request. He actualizado también el README en consecuencia. Ya decís si lo véis relevante :)

Pequeño pull request que facilita la vida al usuario que despliega devicehub. `.env.example` contiene `DEVICEHUB_DOMAIN`, pero `settings.py` espera que haya `DOMAIN`. Si el usuario se copia `.env.example`a `.env`como se suele hacer, se queja porque `DOMAIN` no está definido. En mi opinión es más conveniente como lo deja este pull request. He actualizado también el README en consecuencia. Ya decís si lo véis relevante :)
sergiogimenez added 2 commits 2025-02-25 09:02:04 +00:00
sergiogimenez added the
Kind/Enhancement
 label 2025-02-25 09:02:15 +00:00
sergiogimenez added this to the 2025-q1 🌄 project 2025-02-25 09:02:21 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file:hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
git checkout hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
git checkout main
git merge --ff-only hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
git checkout hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
git rebase main
git checkout main
git merge --no-ff hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
git checkout main
git merge --squash hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
git checkout main
git merge --ff-only hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
git checkout main
git merge hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Test Deployed

this PR is deployed in a domain, so you can see

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Test Deployed
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
2025-q1 🌄
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ereuse/devicehub-django#58
No description provided.
Delete branch "hotfix/use-devicehub-domain-in-settings-as-per-dotenv-file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?