ereuse/devicehub-django
10
1
Fork 0
Code Issues 6 Pull requests 14 Packages Projects Releases Wiki Activity

WIP: Lot Groups view changes and e2e tests #64

Draft
rskthomas wants to merge 11 commits from e2e/lots_group into main
pull from: e2e/lots_group
merge into: ereuse:main
Conversation 1 Commits 11 Files changed 13 +653 -119
rskthomas commented 2025-03-07 18:53:33 +00:00
Owner
Copy link

Dado a lo descripto en ereuse/projectes#130 cambié el UI de lot-groups utilizando django tables. Sólamente toca los archivos de /lots y aquellos pertinente a los tests. La vista de borrar lotes es como se me ha ocurrido, en pos de confirmación y review de los lotes seleccionados.

Los tests realizados son para:

  • Crear lote
  • Editar Lote
  • Eliminar lote
  • Buscar un lote
  • Mostar los lotes archivados
  • ordenar los lotes
  • seleccionar y eliminar todos los lotes

Cosas que no hace este PR:

  • el botón select all selecciona únicamente la paginación actual
    • django-tables no soporta esto django-table doc
    • No creo que sea problema para esta vista, quizás sí para la de dispositivos (dentro de un lote) cuando se intente exportar, etc

image
image
image
image
image

Dado a lo descripto en ereuse/projectes#130 cambié el UI de lot-groups utilizando django tables. Sólamente toca los archivos de /lots y aquellos pertinente a los tests. La vista de borrar lotes es como se me ha ocurrido, en pos de confirmación y review de los lotes seleccionados. Los tests realizados son para: - Crear lote - Editar Lote - Eliminar lote - Buscar un lote - Mostar los lotes archivados - ordenar los lotes - seleccionar y eliminar todos los lotes Cosas que no hace este PR: - el botón select all selecciona únicamente la paginación actual - django-tables no soporta esto [django-table doc ](https://django-tables2.readthedocs.io/en/latest/pages/api-reference.html#django_tables2.columns.CheckBoxColumn) - No creo que sea problema para esta vista, quizás sí para la de dispositivos (dentro de un lote) cuando se intente exportar, etc ![image](/attachments/bad80d68-55ae-444e-9c9a-3a50ff7272a6) ![image](/attachments/b4aa0daf-bc39-49f2-a762-80678cf3edea) ![image](/attachments/dfe3b8ad-4d19-49e8-a5cd-fd260181ab1d) ![image](/attachments/acf4a059-7efd-4979-8a1b-6e7e5c11b043) ![image](/attachments/8fbc1091-6106-4789-a4cb-cdf894881277)
image.png
178 KiB
image.png
120 KiB
image.png
100 KiB
image.png
115 KiB
image.png
138 KiB
rskthomas added 6 commits 2025-03-07 18:53:34 +00:00
rskthomas added 1 commit 2025-03-10 14:06:19 +00:00
rskthomas added 1 commit 2025-03-10 15:07:59 +00:00
rskthomas added 1 commit 2025-03-10 16:18:23 +00:00
rskthomas added 1 commit 2025-03-11 01:36:48 +00:00
rskthomas requested review from pedro 2025-03-11 13:49:31 +00:00
rskthomas commented 2025-03-11 15:42:33 +00:00
Author
Owner
Copy link

@pedro estan implementadas las test e2e en un archivo aparte (creo haber cubierto todos los casos), fijate cuando tengas un tiempito a ver si eran como esperabas o si hay algo que cambiarle

@pedro estan implementadas las test e2e en un archivo aparte (creo haber cubierto todos los casos), fijate cuando tengas un tiempito a ver si eran como esperabas o si hay algo que cambiarle
rskthomas added 1 commit 2025-03-12 13:55:37 +00:00
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin e2e/lots_group:e2e/lots_group
git checkout e2e/lots_group

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff e2e/lots_group
git checkout main
git merge --ff-only e2e/lots_group
git checkout e2e/lots_group
git rebase main
git checkout main
git merge --no-ff e2e/lots_group
git checkout main
git merge --squash e2e/lots_group
git checkout main
git merge --ff-only e2e/lots_group
git checkout main
git merge e2e/lots_group
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
pedro
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Test Deployed

this PR is deployed in a domain, so you can see

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Test Deployed
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ereuse/devicehub-django#64
No description provided.
Delete branch "e2e/lots_group"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?