trustchain-oc1-orchestral
/
authentik
Archived
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sources/saml: fix error ValueError while decoding XML 

closes #812

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
This commit is contained in:
Jens Langhammer 2021-05-01 00:18:57 +02:00
parent e10a7b48b7
commit 379fcf9c1f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
authentik/sources/saml/processors/response.py
View File

@ -54,7 +54,7 @@ class ResponseProcessor:
_source: SAMLSource _source: SAMLSource
_root: Any _root: Any
_root_xml: str _root_xml: bytes
_http_request: HttpRequest _http_request: HttpRequest
@ -69,7 +69,7 @@ class ResponseProcessor:
if not raw_response: if not raw_response:
raise MissingSAMLResponse("Request does not contain 'SAMLResponse'") raise MissingSAMLResponse("Request does not contain 'SAMLResponse'")
# Check if response is compressed, b64 decode it # Check if response is compressed, b64 decode it
self._root_xml = b64decode(raw_response.encode()).decode() self._root_xml = b64decode(raw_response.encode())
self._root = fromstring(self._root_xml) self._root = fromstring(self._root_xml)
if self._source.signing_kp: if self._source.signing_kp:
@ -186,7 +186,7 @@ class ResponseProcessor:
expected=self._source.name_id_policy, expected=self._source.name_id_policy,
got=name_id.attrib["Format"], got=name_id.attrib["Format"],
) )
# transient NameIDs are handeled seperately as they don't have to go through flows. # transient NameIDs are handled separately as they don't have to go through flows.
if name_id.attrib["Format"] == SAML_NAME_ID_FORMAT_TRANSIENT: if name_id.attrib["Format"] == SAML_NAME_ID_FORMAT_TRANSIENT:
return self._handle_name_id_transient(request) return self._handle_name_id_transient(request)