From 7e2a471903e4c2273abba6b3a0cf05fc33ebafdc Mon Sep 17 00:00:00 2001
From: Jens Langhammer <jens.langhammer@beryju.org>
Date: Thu, 4 Feb 2021 10:22:14 +0100
Subject: [PATCH] web: fix linting issues

---
 web/src/elements/router/Route.ts            |  2 +-
 web/src/pages/providers/ProviderListPage.ts | 13 +++++++------
 web/src/pages/providers/ProviderViewPage.ts |  8 ++------
 3 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/web/src/elements/router/Route.ts b/web/src/elements/router/Route.ts
index 2dcfba313..3a52b3559 100644
--- a/web/src/elements/router/Route.ts
+++ b/web/src/elements/router/Route.ts
@@ -1,7 +1,7 @@
 import { html, TemplateResult } from "lit-html";
 
 export const SLUG_REGEX = "[-a-zA-Z0-9_]+";
-export const ID_REGEX = "\d+";
+export const ID_REGEX = "\\d+";
 
 export class Route {
     url: RegExp;
diff --git a/web/src/pages/providers/ProviderListPage.ts b/web/src/pages/providers/ProviderListPage.ts
index d70f24ecf..102b68e12 100644
--- a/web/src/pages/providers/ProviderListPage.ts
+++ b/web/src/pages/providers/ProviderListPage.ts
@@ -6,6 +6,7 @@ import { TablePage } from "../../elements/table/TablePage";
 
 import "../../elements/buttons/ModalButton";
 import "../../elements/buttons/SpinnerButton";
+import "../../elements/buttons/Dropdown";
 import { TableColumn } from "../../elements/table/Table";
 
 @customElement("ak-provider-list")
@@ -58,13 +59,13 @@ export class ProviderListPage extends TablePage<Provider> {
             html`
             <ak-modal-button href="${Provider.adminUrl(`${item.pk}/update/`)}">
                 <ak-spinner-button slot="trigger" class="pf-m-secondary">
-                    Edit
+                    ${gettext("Edit")}
                 </ak-spinner-button>
                 <div slot="modal"></div>
             </ak-modal-button>&nbsp;
             <ak-modal-button href="${Provider.adminUrl(`${item.pk}/delete/`)}">
                 <ak-spinner-button slot="trigger" class="pf-m-danger">
-                    Delete
+                    ${gettext("Delete")}
                 </ak-spinner-button>
                 <div slot="modal"></div>
             </ak-modal-button>
@@ -81,7 +82,7 @@ export class ProviderListPage extends TablePage<Provider> {
             </button>
             <ul class="pf-c-dropdown__menu" hidden>
                 <li>
-                    <ak-modal-button href="${Provider.adminUrl(`/create/?type=OAuth2Provider`)}">
+                    <ak-modal-button href="${Provider.adminUrl("/create/?type=OAuth2Provider")}">
                         <button slot="trigger" class="pf-c-dropdown__menu-item">${gettext("OAuth2/OpenID Provider")}<br>
                             <small>
                                 ${gettext("OAuth2 Provider for generic OAuth and OpenID Connect Applications.")}
@@ -91,7 +92,7 @@ export class ProviderListPage extends TablePage<Provider> {
                     </ak-modal-button>
                 </li>
                 <li>
-                    <ak-modal-button href="${Provider.adminUrl(`/create/?type=ProxyProvider`)}">
+                    <ak-modal-button href="${Provider.adminUrl("/create/?type=ProxyProvider")}">
                         <button slot="trigger" class="pf-c-dropdown__menu-item">${gettext("Proxy Provider")}<br>
                             <small>
                                 ${gettext("Protect applications that don't support any of the other Protocols by using a Reverse-Proxy.")}
@@ -101,7 +102,7 @@ export class ProviderListPage extends TablePage<Provider> {
                     </ak-modal-button>
                 </li>
                 <li>
-                    <ak-modal-button href="${Provider.adminUrl(`/create/?type=SAMLProvider`)}">
+                    <ak-modal-button href="${Provider.adminUrl("/create/?type=SAMLProvider")}">
                         <button slot="trigger" class="pf-c-dropdown__menu-item">${gettext("SAML Provider")}<br>
                             <small>
                                 ${gettext("SAML 2.0 Endpoint for applications which support SAML.")}
@@ -111,7 +112,7 @@ export class ProviderListPage extends TablePage<Provider> {
                     </ak-modal-button>
                 </li>
                 <li>
-                    <ak-modal-button href="${Provider.adminUrl(`/create/saml/from-metadata`)}/">
+                    <ak-modal-button href="${Provider.adminUrl("/create/saml/from-metadata/")}">
                         <button slot="trigger" class="pf-c-dropdown__menu-item">${gettext("SAML Provider from Metadata")}<br>
                             <small>
                                 ${gettext("Create a SAML Provider by importing its Metadata.")}
diff --git a/web/src/pages/providers/ProviderViewPage.ts b/web/src/pages/providers/ProviderViewPage.ts
index b7993a6a7..b2293d38b 100644
--- a/web/src/pages/providers/ProviderViewPage.ts
+++ b/web/src/pages/providers/ProviderViewPage.ts
@@ -1,12 +1,8 @@
-import { gettext } from "django";
-import { customElement, html, LitElement, property, TemplateResult } from "lit-element";
+import { customElement, LitElement, property } from "lit-element";
 import { Provider } from "../../api/Providers";
-import { PBResponse } from "../../api/Client";
-import { TablePage } from "../../elements/table/TablePage";
 
 import "../../elements/buttons/ModalButton";
 import "../../elements/buttons/SpinnerButton";
-import { TableColumn } from "../../elements/table/Table";
 
 @customElement("ak-provider-view")
 export class ProviderViewPage extends LitElement {
@@ -15,7 +11,7 @@ export class ProviderViewPage extends LitElement {
         this.providerID = value.id;
     }
 
-    @property()
+    @property({type: Number})
     set providerID(value: number) {
         Provider.get(value).then((app) => (this.provider = app));
     }