trustchain-oc1-orchestral/authentik
Archived
10
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

sources/ldap: don't sync ldap source when no property mappings are set

Browse source 
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
This commit is contained in:
Jens Langhammer 2021-09-30 18:47:40 +02:00
parent e9bb8c896b
commit 8bce16e6b4
3 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
authentik/sources/ldap/signals.py
View file

@ -25,13 +25,20 @@ from authentik.stages.prompt.signals import password_validate
# pylint: disable=unused-argument # pylint: disable=unused-argument
def sync_ldap_source_on_save(sender, instance: LDAPSource, **_): def sync_ldap_source_on_save(sender, instance: LDAPSource, **_):
"""Ensure that source is synced on save (if enabled)""" """Ensure that source is synced on save (if enabled)"""
if instance.enabled: if not instance.enabled:
for sync_class in [ return
UserLDAPSynchronizer, # Don't sync sources when they don't have any property mappings. This will only happen if:
GroupLDAPSynchronizer, # - the user forgets to set them or
MembershipLDAPSynchronizer, # - the source is newly created, this is the first save event
]: # and the mappings are created with an m2m event
ldap_sync.delay(instance.pk, class_to_path(sync_class)) if not instance.property_mappings.exists() or not instance.property_mappings_group.exists():
return
for sync_class in [
UserLDAPSynchronizer,
GroupLDAPSynchronizer,
MembershipLDAPSynchronizer,
]:
ldap_sync.delay(instance.pk, class_to_path(sync_class))
@receiver(password_validate) @receiver(password_validate)

2
web/src/pages/sources/ldap/LDAPSourceForm.ts
View file

@ -162,7 +162,7 @@ export class LDAPSourceForm extends ModelForm<LDAPSource, string> {
</ak-form-element-horizontal> </ak-form-element-horizontal>
</div> </div>
</ak-form-group> </ak-form-group>
<ak-form-group> <ak-form-group ?expanded=${true}>
<span slot="header"> ${t`LDAP Attribute mapping`} </span> <span slot="header"> ${t`LDAP Attribute mapping`} </span>
<div slot="body" class="pf-c-form"> <div slot="body" class="pf-c-form">
<ak-form-element-horizontal <ak-form-element-horizontal

1
web/src/pages/sources/ldap/LDAPSourceViewPage.ts
View file

@ -207,6 +207,7 @@ export class LDAPSourceViewPage extends LitElement {
</div> </div>
<div class="pf-c-card__footer"> <div class="pf-c-card__footer">
<ak-action-button <ak-action-button
class="pf-m-primary"
.apiRequest=${() => { .apiRequest=${() => {
return new SourcesApi(DEFAULT_CONFIG) return new SourcesApi(DEFAULT_CONFIG)
.sourcesLdapPartialUpdate({ .sourcesLdapPartialUpdate({