admin: improve policy binding listing by showing Target object type

passbook/admin/templates/administration/policy_binding/list.html

@@ -28,30 +28,51 @@
         <table class="pf-c-table pf-m-compact pf-m-grid-xl" role="grid">
             <thead>
                 <tr role="row">
-                    <th role="columnheader" scope="col">{% trans 'Enabled' %}</th>
                     <th role="columnheader" scope="col">{% trans 'Policy' %}</th>
-                    <th role="columnheader" scope="col">{% trans 'Target' %}</th>
+                    <th role="columnheader" scope="col">{% trans 'Enabled' %}</th>
+                    <th role="columnheader" scope="col">{% trans 'Order' %}</th>
+                    <th role="columnheader" scope="col">{% trans 'Timeout' %}</th>
                     <th role="cell"></th>
                 </tr>
             </thead>
-            <tbody role="rowgroup" class="pf-m-expanded">
+            <tbody role="rowgroup">
-                {% for binding in object_list %}
+                {% for pbm in object_list %}
-                <tr role="row pf-c-table__expandable-row pf-m-expanded">
+                    <tr role="role">
+                        <td>
+                            {{ pbm }}
+                            <small>
+                                {{ pbm|fieldtype }}
+                            </small>
+                        </td>
+                        <td></td>
+                        <td></td>
+                        <td></td>
+                        <td></td>
+                    </tr>
+                    {% for binding in pbm.bindings %}
+                    <tr class="row pf-c-table__expandable-row pf-m-expanded">
+                        <th role="cell">
+                            <div>{{ binding.policy }}</div>
+                            <small>
+                                {{ binding.policy|fieldtype }}
+                            </small>
+                        </th>
                         <th role="cell">
                             <div>{{ binding.enabled }}</div>
                         </th>
                         <th role="cell">
-                        <div>{{ binding.policy }}</div>
+                            <div>{{ binding.order }}</div>
                         </th>
                         <th role="cell">
-                        <div>{{ binding.target|verbose_name }}</div>
+                            <div>{{ binding.timeout }}</div>
                         </th>
-                    <td>
+                        <td class="pb-table-action" role="cell">
                             <a class="pf-c-button pf-m-secondary" href="{% url 'passbook_admin:policy-binding-update' pk=binding.pk %}?back={{ request.get_full_path }}">{% trans 'Edit' %}</a>
                             <a class="pf-c-button pf-m-danger" href="{% url 'passbook_admin:policy-binding-delete' pk=binding.pk %}?back={{ request.get_full_path }}">{% trans 'Delete' %}</a>
                         </td>
                     </tr>
                     {% endfor %}
+                {% endfor %}
             </tbody>
         </table>
         <div class="pf-c-toolbar" id="page-layout-table-simple-toolbar-bottom">

passbook/admin/views/policies_bindings.py

@@ -4,6 +4,7 @@ from django.contrib.auth.mixins import (
     PermissionRequiredMixin as DjangoPermissionRequiredMixin,
 )
 from django.contrib.messages.views import SuccessMessageMixin
+from django.db.models import QuerySet
 from django.urls import reverse_lazy
 from django.utils.translation import ugettext as _
 from django.views.generic import ListView, UpdateView
@@ -12,7 +13,7 @@ from guardian.mixins import PermissionListMixin, PermissionRequiredMixin
 from passbook.admin.views.utils import DeleteMessageView
 from passbook.lib.views import CreateAssignPermView
 from passbook.policies.forms import PolicyBindingForm
-from passbook.policies.models import PolicyBinding
+from passbook.policies.models import PolicyBinding, PolicyBindingModel
 
 
 class PolicyBindingListView(LoginRequiredMixin, PermissionListMixin, ListView):
@@ -22,7 +23,20 @@ class PolicyBindingListView(LoginRequiredMixin, PermissionListMixin, ListView):
     permission_required = "passbook_policies.view_policybinding"
     paginate_by = 10
     ordering = ["order", "target"]
-    template_name = "administration/policybinding/list.html"
+    template_name = "administration/policy_binding/list.html"
+
+    def get_queryset(self) -> QuerySet:
+        # Since `select_subclasses` does not work with a foreign key, we have to do two queries here
+        # First, get all pbm objects that have bindings attached
+        objects = (
+            PolicyBindingModel.objects.filter(policies__isnull=False)
+            .select_subclasses()
+            .select_related()
+            .order_by("pk")
+        )
+        for pbm in objects:
+            pbm.bindings = PolicyBinding.objects.filter(target__pk=pbm.pbm_uuid)
+        return objects
 
 
 class PolicyBindingCreateView(

passbook/lib/widgets.py

@@ -1,7 +1,5 @@
 """Utility Widgets"""
-from functools import partial
 from itertools import groupby
-from operator import attrgetter
 
 from django.forms.models import ModelChoiceField, ModelChoiceIterator
 

passbook/static/static/passbook/pf.css

@@ -235,3 +235,9 @@ input[data-is-monospace] {
 .pf-c-alert pre {
     white-space: pre-wrap;
 }
+
+/* Table buttons (Don't wrap, align) */
+.pb-table-action {
+    white-space: nowrap !important;
+    padding: var(--pf-c-table--cell--PaddingTop) var(--pf-c-table--cell--PaddingRight) var(--pf-c-table--cell--PaddingBottom) var(--pf-c-table--cell--PaddingLeft) !important;
+}