trustchain-oc1-orchestral/authentik
Archived
10
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

sources/ldap: use entryDN attribute from ldap3 as opposed to implicit DN attribute

Browse source
This commit is contained in:
Jens Langhammer 2021-02-05 11:43:13 +01:00
parent 51cbb7cc8e
commit b0e3b8b39d
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
authentik/sources/ldap/sync/users.py
View file

@ -29,16 +29,17 @@ class UserLDAPSynchronizer(BaseLDAPSynchronizer):
user_count = 0
for user in users:
attributes = user.get("attributes", {})
user_dn = user.get("entryDN", "")
if self._source.object_uniqueness_field not in attributes:
self._logger.warning(
"Cannot find uniqueness Field in attributes",
attributes=attributes.keys(),
dn=attributes.get(LDAP_DISTINGUISHED_NAME, ""),
dn=user_dn,
)
continue
uniq = attributes[self._source.object_uniqueness_field]
try:
defaults = self._build_object_properties(attributes)
defaults = self._build_object_properties(user_dn, **attributes)
user, created = User.objects.update_or_create(
**{
f"attributes__{LDAP_UNIQUENESS}": uniq,
@ -64,7 +65,7 @@ class UserLDAPSynchronizer(BaseLDAPSynchronizer):
return user_count
def _build_object_properties(
self, attributes: dict[str, Any]
self, user_dn: str, **kwargs
) -> dict[str, dict[Any, Any]]:
properties = {"attributes": {}}
for mapping in self._source.property_mappings.all().select_subclasses():
@ -72,7 +73,9 @@ class UserLDAPSynchronizer(BaseLDAPSynchronizer):
continue
mapping: LDAPPropertyMapping
try:
value = mapping.evaluate(user=None, request=None, ldap=attributes)
value = mapping.evaluate(
user=None, request=None, ldap=kwargs, dn=user_dn
)
if value is None:
continue
object_field = mapping.object_field
@ -87,11 +90,9 @@ class UserLDAPSynchronizer(BaseLDAPSynchronizer):
"Mapping failed to evaluate", exc=exc, mapping=mapping
)
continue
if self._source.object_uniqueness_field in attributes:
properties["attributes"][LDAP_UNIQUENESS] = attributes.get(
if self._source.object_uniqueness_field in kwargs:
properties["attributes"][LDAP_UNIQUENESS] = kwargs.get(
self._source.object_uniqueness_field
)
properties["attributes"][LDAP_DISTINGUISHED_NAME] = attributes.get(
"distinguishedName", attributes.get("dn")
)
properties["attributes"][LDAP_DISTINGUISHED_NAME] = user_dn
return properties