web: sometimes I wish I had lower standards

Anyway, this was a very stupid bug, because by definition function
definition arguments don't have uses, they're being defined, not
implemented.  Fixed, conf fixed to compensate, and consequences
conquered.
This commit is contained in:
Ken Sternberg 2023-10-17 14:48:06 -07:00
parent 332ef59860
commit c77a471d5e
3 changed files with 25 additions and 21 deletions

View File

@ -15,6 +15,15 @@
"linebreak-style": ["error", "unix"], "linebreak-style": ["error", "unix"],
"quotes": ["error", "double", { "avoidEscape": true }], "quotes": ["error", "double", { "avoidEscape": true }],
"semi": ["error", "always"], "semi": ["error", "always"],
"@typescript-eslint/ban-ts-comment": "off" "@typescript-eslint/ban-ts-comment": "off",
"no-unused-vars": "off",
"@typescript-eslint/no-unused-vars": [
"error",
{
"argsIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^_"
}
]
} }
} }

View File

@ -31,6 +31,9 @@ async function getCommitMessage() {
return await ApplicationWizardView.successMessage; return await ApplicationWizardView.successMessage;
} }
const SUCCESS_MESSAGE = "Your application has been saved";
const EXPLICIT_CONSENT = "default-provider-authorization-explicit-consent";
describe("Configure Applications with the Application Wizard", () => { describe("Configure Applications with the Application Wizard", () => {
it("Should configure a simple LDAP Application", async () => { it("Should configure a simple LDAP Application", async () => {
await reachTheProvider("New LDAP Application"); await reachTheProvider("New LDAP Application");
@ -46,7 +49,7 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await expect(getCommitMessage()).toHaveText("Your application has been saved"); await expect(getCommitMessage()).toHaveText(SUCCESS_MESSAGE);
}); });
it("Should configure a simple Oauth2 Application", async () => { it("Should configure a simple Oauth2 Application", async () => {
@ -59,13 +62,11 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await ApplicationWizardView.oauth.setAuthorizationFlow( await ApplicationWizardView.oauth.setAuthorizationFlow(EXPLICIT_CONSENT);
"default-provider-authorization-explicit-consent",
);
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await expect(getCommitMessage()).toHaveText("Your application has been saved"); await expect(getCommitMessage()).toHaveText(SUCCESS_MESSAGE);
}); });
it("Should configure a simple SAML Application", async () => { it("Should configure a simple SAML Application", async () => {
@ -78,14 +79,12 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await ApplicationWizardView.saml.setAuthorizationFlow( await ApplicationWizardView.saml.setAuthorizationFlow(EXPLICIT_CONSENT);
"default-provider-authorization-explicit-consent",
);
await ApplicationWizardView.saml.acsUrl.setValue("http://example.com:8000/"); await ApplicationWizardView.saml.acsUrl.setValue("http://example.com:8000/");
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await expect(getCommitMessage()).toHaveText("Your application has been saved"); await expect(getCommitMessage()).toHaveText(SUCCESS_MESSAGE);
}); });
it("Should configure a simple SCIM Application", async () => { it("Should configure a simple SCIM Application", async () => {
@ -103,7 +102,7 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await expect(getCommitMessage()).toHaveText("Your application has been saved"); await expect(getCommitMessage()).toHaveText(SUCCESS_MESSAGE);
}); });
it("Should configure a simple Radius Application", async () => { it("Should configure a simple Radius Application", async () => {
@ -120,7 +119,7 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await expect(getCommitMessage()).toHaveText("Your application has been saved"); await expect(getCommitMessage()).toHaveText(SUCCESS_MESSAGE);
}); });
it("Should configure a simple Transparent Proxy Application", async () => { it("Should configure a simple Transparent Proxy Application", async () => {
@ -132,9 +131,7 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await ApplicationWizardView.transparentProxy.setAuthorizationFlow( await ApplicationWizardView.transparentProxy.setAuthorizationFlow(EXPLICIT_CONSENT);
"default-provider-authorization-explicit-consent",
);
await ApplicationWizardView.transparentProxy.externalHost.setValue( await ApplicationWizardView.transparentProxy.externalHost.setValue(
"http://external.example.com", "http://external.example.com",
); );
@ -145,7 +142,7 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await expect(getCommitMessage()).toHaveText("Your application has been saved"); await expect(getCommitMessage()).toHaveText(SUCCESS_MESSAGE);
}); });
it("Should configure a simple Forward Proxy Application", async () => { it("Should configure a simple Forward Proxy Application", async () => {
@ -157,9 +154,7 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await ApplicationWizardView.forwardProxy.setAuthorizationFlow( await ApplicationWizardView.forwardProxy.setAuthorizationFlow(EXPLICIT_CONSENT);
"default-provider-authorization-explicit-consent",
);
await ApplicationWizardView.forwardProxy.externalHost.setValue( await ApplicationWizardView.forwardProxy.externalHost.setValue(
"http://external.example.com", "http://external.example.com",
); );
@ -167,6 +162,6 @@ describe("Configure Applications with the Application Wizard", () => {
await ApplicationWizardView.nextButton.click(); await ApplicationWizardView.nextButton.click();
await ApplicationWizardView.pause(); await ApplicationWizardView.pause();
await expect(getCommitMessage()).toHaveText("Your application has been saved"); await expect(getCommitMessage()).toHaveText(SUCCESS_MESSAGE);
}); });
}); });

View File

@ -209,7 +209,7 @@ export const config: Options.Testrunner = {
* @param {Array.<String>} specs List of spec file paths that are to be run * @param {Array.<String>} specs List of spec file paths that are to be run
* @param {object} browser instance of created browser/device session * @param {object} browser instance of created browser/device session
*/ */
before: function (capabilities, specs) {}, before: function (_capabilities, _specs) {},
/** /**
* Runs before a WebdriverIO command gets executed. * Runs before a WebdriverIO command gets executed.
* @param {string} commandName hook command name * @param {string} commandName hook command name