root(minor): get rid of duplicate settings

This commit is contained in:
Langhammer, Jens 2019-10-04 16:09:35 +02:00
parent 43dd858cd5
commit d21ec6c9a5
2 changed files with 8 additions and 7 deletions

View file

@ -1,9 +1,12 @@
"""passbook access helper classes""" """passbook access helper classes"""
from typing import List, Tuple
from django.contrib import messages from django.contrib import messages
from django.http import HttpRequest
from django.utils.translation import gettext as _ from django.utils.translation import gettext as _
from structlog import get_logger from structlog import get_logger
from passbook.core.models import Application from passbook.core.models import Application, Provider, User
from passbook.policy.engine import PolicyEngine from passbook.policy.engine import PolicyEngine
LOGGER = get_logger() LOGGER = get_logger()
@ -13,9 +16,9 @@ class AccessMixin:
Provider functions to check application access, etc""" Provider functions to check application access, etc"""
# request is set by view but since this Mixin has no base class # request is set by view but since this Mixin has no base class
request = None request: HttpRequest = None
def provider_to_application(self, provider): def provider_to_application(self, provider: Provider) -> Application:
"""Lookup application assigned to provider, throw error if no application assigned""" """Lookup application assigned to provider, throw error if no application assigned"""
try: try:
return provider.application return provider.application
@ -25,9 +28,9 @@ class AccessMixin:
})) }))
raise exc raise exc
def user_has_access(self, application, user): def user_has_access(self, application: Application, user: User) -> Tuple[bool, List[str]]:
"""Check if user has access to application.""" """Check if user has access to application."""
LOGGER.debug("Checking permissions of %s on application %s...", user, application) LOGGER.debug("Checking permissions", user=user, application=application)
policy_engine = PolicyEngine(application.policies.all()) policy_engine = PolicyEngine(application.policies.all())
policy_engine.for_user(user).with_request(self.request).build() policy_engine.for_user(user).with_request(self.request).build()
return policy_engine.result return policy_engine.result

View file

@ -47,8 +47,6 @@ AUTH_USER_MODEL = 'passbook_core.User'
CSRF_COOKIE_NAME = 'passbook_csrf' CSRF_COOKIE_NAME = 'passbook_csrf'
SESSION_COOKIE_NAME = 'passbook_session' SESSION_COOKIE_NAME = 'passbook_session'
SESSION_ENGINE = "django.contrib.sessions.backends.db"
SESSION_CACHE_ALIAS = "default"
LANGUAGE_COOKIE_NAME = 'passbook_language' LANGUAGE_COOKIE_NAME = 'passbook_language'
AUTHENTICATION_BACKENDS = [ AUTHENTICATION_BACKENDS = [