From d8d9890a41cf9c5c64ed036a5b5cf7cda8c14d19 Mon Sep 17 00:00:00 2001
From: Ken Sternberg <ken@goauthentik.io>
Date: Fri, 22 Sep 2023 13:02:24 -0700
Subject: [PATCH] web/adding tests: added comments and cleaned up some
 administrative features.

---
 tests/wdio/.eslintignore            |  4 ----
 tests/wdio/.prettierignore          |  7 -------
 tests/wdio/test/pageobjects/page.ts | 13 +++++++++++--
 3 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/tests/wdio/.eslintignore b/tests/wdio/.eslintignore
index 773a27bf1..2e29534b7 100644
--- a/tests/wdio/.eslintignore
+++ b/tests/wdio/.eslintignore
@@ -1,8 +1,4 @@
 # don't ever lint node_modules
 node_modules
-# don't lint build output (make sure it's set to your correct build folder name)
-dist
 # don't lint nyc coverage output
 coverage
-src/locale-codes.ts
-storybook-static/
diff --git a/tests/wdio/.prettierignore b/tests/wdio/.prettierignore
index 0e7baef47..2e29534b7 100644
--- a/tests/wdio/.prettierignore
+++ b/tests/wdio/.prettierignore
@@ -1,11 +1,4 @@
 # don't ever lint node_modules
 node_modules
-# don't lint build output (make sure it's set to your correct build folder name)
-dist
 # don't lint nyc coverage output
 coverage
-# Import order matters
-poly.ts
-src/locale-codes.ts
-src/locales/
-storybook-static/
diff --git a/tests/wdio/test/pageobjects/page.ts b/tests/wdio/test/pageobjects/page.ts
index 928e22f7f..ef915c6c5 100644
--- a/tests/wdio/test/pageobjects/page.ts
+++ b/tests/wdio/test/pageobjects/page.ts
@@ -3,8 +3,8 @@ import { browser } from "@wdio/globals";
 const CLICK_TIME_DELAY = 250;
 
 /**
- * main page object containing all methods, selectors and functionality
- * that is shared across all page objects
+ * Main page object containing all methods, selectors and functionality that is shared across all
+ * page objects
  */
 export default class Page {
     /**
@@ -22,6 +22,15 @@ export default class Page {
         return browser.pause(CLICK_TIME_DELAY);
     }
 
+    /**
+     * Target a specific entry in SearchSelect. Requires that the SearchSelect have the `name`
+     * attribute set, so that the managed selector can find the *right* SearchSelect if there are
+     * multiple open SearchSelects on the board. See `./ldap-form.view:LdapForm.setBindFlow` for an
+     * example, and see `./oauth-form.view:OauthForm:setAuthorizationFlow` for a further example of
+     * why it would be hard to simplify this further (`flow` vs `tentanted-flow` vs a straight-up
+     * SearchSelect each have different a `searchSelector`).
+     */
+
     async searchSelect(searchSelector: string, managedSelector: string, buttonSelector: string) {
         const inputBind = await $(searchSelector);
         await inputBind.click();