From ed4daa64fe158350eb02d4fd5f6be48c82fc06e8 Mon Sep 17 00:00:00 2001 From: Jens Langhammer Date: Sun, 21 Jun 2020 18:44:08 +0200 Subject: [PATCH] e2e: save screenshots with timestamp instead of class name --- e2e/test_enroll_2_step.py | 2 +- e2e/test_provider_oidc.py | 2 +- e2e/utils.py | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/e2e/test_enroll_2_step.py b/e2e/test_enroll_2_step.py index 821a6e52b..e4e7dbd0f 100644 --- a/e2e/test_enroll_2_step.py +++ b/e2e/test_enroll_2_step.py @@ -286,7 +286,7 @@ class TestEnroll2Step(SeleniumTestCase): self.driver.get(self.live_server_url) self.setup_test_enroll_2_step() self.wait.until( - ec.presence_of_element_located(By.CSS_SELECTOR, "[role=enroll]") + ec.presence_of_element_located((By.CSS_SELECTOR, "[role=enroll]")) ) self.driver.find_element(By.CSS_SELECTOR, "[role=enroll]").click() diff --git a/e2e/test_provider_oidc.py b/e2e/test_provider_oidc.py index 259ab5528..8e6083c63 100644 --- a/e2e/test_provider_oidc.py +++ b/e2e/test_provider_oidc.py @@ -219,7 +219,7 @@ class TestProviderOIDC(SeleniumTestCase): self.driver.find_element(By.CSS_SELECTOR, "[type=submit]").click() self.wait.until( - ec.presence_of_element_located(By.XPATH, "//a[contains(@href, '/profile')]") + ec.presence_of_element_located((By.XPATH, "//a[contains(@href, '/profile')]")) ) self.driver.find_element(By.XPATH, "//a[contains(@href, '/profile')]").click() self.assertEqual( diff --git a/e2e/utils.py b/e2e/utils.py index 81acc3739..4b74176b4 100644 --- a/e2e/utils.py +++ b/e2e/utils.py @@ -1,4 +1,5 @@ """passbook e2e testing utilities""" +from time import time from functools import lru_cache from glob import glob from importlib.util import module_from_spec, spec_from_file_location @@ -55,7 +56,7 @@ class SeleniumTestCase(StaticLiveServerTestCase): ) def tearDown(self): - self.driver.save_screenshot(f"out/{self.__class__.__name__}.png") + self.driver.save_screenshot(f"out/{time()}.png") self.driver.quit() super().tearDown()