695719540b
Fix duplicate cookies when using file system store.
168 lines
4.7 KiB
Go
168 lines
4.7 KiB
Go
package application
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"math"
|
|
"net/http"
|
|
"net/url"
|
|
"os"
|
|
"path"
|
|
"strings"
|
|
|
|
"github.com/gorilla/securecookie"
|
|
"github.com/gorilla/sessions"
|
|
"github.com/redis/go-redis/v9"
|
|
"goauthentik.io/api/v3"
|
|
"goauthentik.io/internal/config"
|
|
"goauthentik.io/internal/outpost/proxyv2/codecs"
|
|
"goauthentik.io/internal/outpost/proxyv2/constants"
|
|
"goauthentik.io/internal/outpost/proxyv2/redisstore"
|
|
)
|
|
|
|
const RedisKeyPrefix = "authentik_proxy_session_"
|
|
|
|
func (a *Application) getStore(p api.ProxyOutpostConfig, externalHost *url.URL) sessions.Store {
|
|
maxAge := 0
|
|
if p.AccessTokenValidity.IsSet() {
|
|
t := p.AccessTokenValidity.Get()
|
|
// Add one to the validity to ensure we don't have a session with indefinite length
|
|
maxAge = int(*t) + 1
|
|
}
|
|
if a.isEmbedded {
|
|
client := redis.NewClient(&redis.Options{
|
|
Addr: fmt.Sprintf("%s:%d", config.Get().Redis.Host, config.Get().Redis.Port),
|
|
// Username: config.Get().Redis.Password,
|
|
Password: config.Get().Redis.Password,
|
|
DB: config.Get().Redis.DB,
|
|
})
|
|
|
|
// New default RedisStore
|
|
rs, err := redisstore.NewRedisStore(context.Background(), client)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
rs.KeyPrefix(RedisKeyPrefix)
|
|
rs.Options(sessions.Options{
|
|
HttpOnly: true,
|
|
Secure: strings.ToLower(externalHost.Scheme) == "https",
|
|
Domain: *p.CookieDomain,
|
|
SameSite: http.SameSiteLaxMode,
|
|
MaxAge: maxAge,
|
|
Path: "/",
|
|
})
|
|
|
|
a.log.Trace("using redis session backend")
|
|
return rs
|
|
}
|
|
dir := os.TempDir()
|
|
cs := sessions.NewFilesystemStore(dir)
|
|
cs.Codecs = codecs.CodecsFromPairs(maxAge, []byte(*p.CookieSecret))
|
|
// https://github.com/markbates/goth/commit/7276be0fdf719ddff753f3574ef0f967e4a5a5f7
|
|
// set the maxLength of the cookies stored on the disk to a larger number to prevent issues with:
|
|
// securecookie: the value is too long
|
|
// when using OpenID Connect , since this can contain a large amount of extra information in the id_token
|
|
|
|
// Note, when using the FilesystemStore only the session.ID is written to a browser cookie, so this is explicit for the storage on disk
|
|
cs.MaxLength(math.MaxInt)
|
|
cs.Options.HttpOnly = true
|
|
cs.Options.Secure = strings.ToLower(externalHost.Scheme) == "https"
|
|
cs.Options.Domain = *p.CookieDomain
|
|
cs.Options.SameSite = http.SameSiteLaxMode
|
|
cs.Options.MaxAge = maxAge
|
|
cs.Options.Path = "/"
|
|
a.log.WithField("dir", dir).Trace("using filesystem session backend")
|
|
return cs
|
|
}
|
|
|
|
func (a *Application) SessionName() string {
|
|
return a.sessionName
|
|
}
|
|
|
|
func (a *Application) getAllCodecs() []securecookie.Codec {
|
|
apps := a.srv.Apps()
|
|
cs := []securecookie.Codec{}
|
|
for _, app := range apps {
|
|
cs = append(cs, codecs.CodecsFromPairs(0, []byte(*app.proxyConfig.CookieSecret))...)
|
|
}
|
|
return cs
|
|
}
|
|
|
|
func (a *Application) Logout(ctx context.Context, filter func(c Claims) bool) error {
|
|
if _, ok := a.sessions.(*sessions.FilesystemStore); ok {
|
|
files, err := os.ReadDir(os.TempDir())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, file := range files {
|
|
s := sessions.Session{}
|
|
if !strings.HasPrefix(file.Name(), "session_") {
|
|
continue
|
|
}
|
|
fullPath := path.Join(os.TempDir(), file.Name())
|
|
data, err := os.ReadFile(fullPath)
|
|
if err != nil {
|
|
a.log.WithError(err).Warning("failed to read file")
|
|
continue
|
|
}
|
|
err = securecookie.DecodeMulti(
|
|
a.SessionName(), string(data),
|
|
&s.Values, a.getAllCodecs()...,
|
|
)
|
|
if err != nil {
|
|
a.log.WithError(err).Trace("failed to decode session")
|
|
continue
|
|
}
|
|
rc, ok := s.Values[constants.SessionClaims]
|
|
if !ok || rc == nil {
|
|
continue
|
|
}
|
|
claims := s.Values[constants.SessionClaims].(Claims)
|
|
if filter(claims) {
|
|
a.log.WithField("path", fullPath).Trace("deleting session")
|
|
err := os.Remove(fullPath)
|
|
if err != nil {
|
|
a.log.WithError(err).Warning("failed to delete session")
|
|
continue
|
|
}
|
|
}
|
|
}
|
|
}
|
|
if rs, ok := a.sessions.(*redisstore.RedisStore); ok {
|
|
client := rs.Client()
|
|
keys, err := client.Keys(ctx, fmt.Sprintf("%s*", RedisKeyPrefix)).Result()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
serializer := redisstore.GobSerializer{}
|
|
for _, key := range keys {
|
|
v, err := client.Get(ctx, key).Result()
|
|
if err != nil {
|
|
a.log.WithError(err).Warning("failed to get value")
|
|
continue
|
|
}
|
|
s := sessions.Session{}
|
|
err = serializer.Deserialize([]byte(v), &s)
|
|
if err != nil {
|
|
a.log.WithError(err).Warning("failed to deserialize")
|
|
continue
|
|
}
|
|
c := s.Values[constants.SessionClaims]
|
|
if c == nil {
|
|
continue
|
|
}
|
|
claims := c.(Claims)
|
|
if filter(claims) {
|
|
a.log.WithField("key", key).Trace("deleting session")
|
|
_, err := client.Del(ctx, key).Result()
|
|
if err != nil {
|
|
a.log.WithError(err).Warning("failed to delete key")
|
|
continue
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|