f5394da9f7
* web: Replace ad-hoc toggle control with ak-toggle-group
This commit replaces various ad-hoc implementations of the Patternfly Toggle Group HTML with a web
component that encapsulates all of the needed behavior and exposes a single API with a single event
handler, return the value of the option clicked.
The results are: Lots of visual clutter is eliminated. A single link of:
```
<div class="pf-c-toggle-group__item">
<button
class="pf-c-toggle-group__button ${this.mode === ProxyMode.Proxy
? "pf-m-selected"
: ""}"
type="button"
@click=${() => {
this.mode = ProxyMode.Proxy;
}}>
<span class="pf-c-toggle-group__text">${msg("Proxy")}</span>
</button>
</div>
<div class="pf-c-divider pf-m-vertical" role="separator"></div>
```
Now looks like:
```
<option value=${ProxyMode.Proxy}>${msg("Proxy")}</option>
```
This also means that the three pages that used the Patternfly Toggle Group could eliminate all of
their Patternfly PFToggleGroup needs, as well as the `justify-content: center` extension, which also
eliminated the `css` import.
The savings aren't as spectacular as I'd hoped: removed 178 lines, but added 123; total savings 55
lines of code. I still count this a win: we need never write another toggle component again, and
any bugs, extensions or features we may want to add can be centralized or forked without risking the
whole edifice.
* web: minor code formatting issue.
* web: adding a storybook for the ak-toggle-group component
* Bugs found by CI/CD.
* web: Replace ad-hoc search for CryptoCertificateKeyPairs with crypto-certificate-search (#6475)
* web: Replace ad-hoc search for CryptoCertificateKeyPairs with ak-crypto-certeficate-search
This commit replaces various ad-hoc implementations of `search-select` for CryptoCertificateKeyPairs
with a web component that encapsulates all of the needed behavior and exposes a single API.
The results are: Lots of visual clutter is eliminated. A single search of:
```HTML
<ak-search-select
.fetchObjects=${async (query?: string): Promise<CertificateKeyPair[]> => {
const args: CryptoCertificatekeypairsListRequest = {
ordering: "name",
hasKey: true,
includeDetails: false,
};
if (query !== undefined) {
args.search = query;
}
const certificates = await new CryptoApi(
DEFAULT_CONFIG,
).cryptoCertificatekeypairsList(args);
return certificates.results;
}}
.renderElement=${(item: CertificateKeyPair): string => {
return item.name;
}}
.value=${(item: CertificateKeyPair | undefined): string | undefined => {
return item?.pk;
}}
.selected=${(item: CertificateKeyPair): boolean => {
return this.instance?.tlsVerification === item.pk;
}}
?blankable=${true}
>
</ak-search-select>
```
Now looks like:
```HTML
<ak-crypto-certificate-search certificate=${this.instance?.tlsVerification}>
</ak-crypto-certificate-search>
```
There are three searches that do not require there to be a valid key with the certificate; these are
supported with the boolean property `nokey`; likewise, there is one search (in SAMLProviderForm)
that states that if there is no current certificate in the SAMLProvider and only one certificate can
be found in the Authentik database, use that one; this is supported with the boolean property
`singleton`.
These changes replace 382 lines of object-oriented invocations with 36 lines of declarative
configuration, and 98 lines for the class. Overall, the code for "find a crypto certificate" has
been reduced by 46%.
Suggestions for a better word than `singleton` are welcome!
* web: display tests for CryptoCertificateKeypair search
This adds a Storybook for the CryptoCertificateKeypair search, including
a mock fetch of the data. In the course of running the tests, we discovered
that including the SearchSelect _class_ won't include the customElement declaration
unless you include the whole file! Other bugs found: including the CSS from
Storybook is different from that of LitElement native, so much so that the
adapter needed to be included. FlowSearch had a similar bug. The problem
only manifests when building via Webpack (which Storybook uses) and not
Rollup, but we should support both in distribution.
65 lines
2.1 KiB
JSON
65 lines
2.1 KiB
JSON
{
|
|
"compilerOptions": {
|
|
"strict": true,
|
|
"paths": {
|
|
"@goauthentik/app/*": ["src/*"],
|
|
"@goauthentik/admin/*": ["src/admin/*"],
|
|
"@goauthentik/common/*": ["src/common/*"],
|
|
"@goauthentik/components/*": ["src/components/*"],
|
|
"@goauthentik/docs/*": ["../website/docs/*"],
|
|
"@goauthentik/elements/*": ["src/elements/*"],
|
|
"@goauthentik/flow/*": ["src/flow/*"],
|
|
"@goauthentik/locales/*": ["src/locales/*"],
|
|
"@goauthentik/polyfill/*": ["src/polyfill/*"],
|
|
"@goauthentik/standalone/*": ["src/standalone/*"],
|
|
"@goauthentik/user/*": ["src/user/*"]
|
|
},
|
|
"baseUrl": ".",
|
|
"esModuleInterop": true,
|
|
"skipLibCheck": true,
|
|
"forceConsistentCasingInFileNames": true,
|
|
"experimentalDecorators": true,
|
|
"sourceMap": true,
|
|
"target": "esnext",
|
|
"module": "esnext",
|
|
"moduleResolution": "node",
|
|
"lib": [
|
|
"ES5",
|
|
"ES2015",
|
|
"ES2016",
|
|
"ES2017",
|
|
"ES2018",
|
|
"ES2019",
|
|
"ES2020",
|
|
"ESNext",
|
|
"DOM",
|
|
"DOM.Iterable",
|
|
"WebWorker"
|
|
],
|
|
"noUnusedLocals": true,
|
|
"noImplicitReturns": true,
|
|
"noFallthroughCasesInSwitch": true,
|
|
"strictBindCallApply": true,
|
|
"strictFunctionTypes": true,
|
|
"strictNullChecks": true,
|
|
"allowUnreachableCode": false,
|
|
"allowUnusedLabels": false,
|
|
"useDefineForClassFields": false,
|
|
"alwaysStrict": true,
|
|
"noImplicitAny": true,
|
|
"plugins": [
|
|
{
|
|
"name": "ts-lit-plugin",
|
|
"strict": true,
|
|
"rules": {
|
|
"no-unknown-tag-name": "off",
|
|
"no-missing-import": "off",
|
|
"no-incompatible-type-binding": "off",
|
|
"no-unknown-property": "off",
|
|
"no-unknown-attribute": "off"
|
|
}
|
|
}
|
|
]
|
|
}
|
|
}
|