From 15fa4546d118907f1b6cdff731c981f4c1677697 Mon Sep 17 00:00:00 2001 From: Cayo Puigdefabregas Date: Mon, 25 Oct 2021 12:20:16 +0200 Subject: [PATCH] fixing general case for devices --- ereuse_devicehub/resources/device/metrics.py | 6 ++---- tests/test_metrics.py | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/ereuse_devicehub/resources/device/metrics.py b/ereuse_devicehub/resources/device/metrics.py index eaa72f04..898fc5d8 100644 --- a/ereuse_devicehub/resources/device/metrics.py +++ b/ereuse_devicehub/resources/device/metrics.py @@ -137,10 +137,8 @@ class Metrics(MetricsMix): if the action is one trade action, is possible than have a list of confirmations. Get the doble confirm for to know if this trade is confirmed or not. """ - if hasattr(self.act, 'acceptances'): - accept = self.act.acceptances[-1] - if accept.t == 'Confirm' and accept.user == self.act.user_to: - return True + if self.device.trading == 'TradeConfirmed': + return True return False def get_trade(self): diff --git a/tests/test_metrics.py b/tests/test_metrics.py index aeffa538..efdb26e4 100644 --- a/tests/test_metrics.py +++ b/tests/test_metrics.py @@ -304,7 +304,6 @@ def test_visual_metrics_for_old_owners(user: UserClient, user2: UserClient): @pytest.mark.usefixtures(conftest.app_context.__name__) def test_bug_trade_confirmed(user: UserClient, user2: UserClient): """When the receiber do a Trade, then the confirmation is wrong.""" - # Insert computer lenovo = yaml2json('desktop-9644w8n-lenovo-0169622.snapshot') snap1, _ = user.post(json_encode(lenovo), res=ma.Snapshot) lot, _ = user.post({'name': 'MyLot'}, res=Lot)