trustchain-oc1-orchestral
/
devicehub-teal
Archived
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

put the forze of validation in the schemas

This commit is contained in:
Cayo Puigdefabregas 2022-12-05 19:17:54 +01:00
parent d6bee33601
commit 5e8cf78751
3 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ereuse_devicehub/migrations/versions/564952310b17_add_vendor_family_in_device.py
View File

@ -1,7 +1,7 @@
"""add vendor family in device """add vendor family in device
Revision ID: 564952310b17 Revision ID: 564952310b17
Revises: d65745749e34 Revises: af038a8a388c
Create Date: 2022-11-14 13:12:22.916848 Create Date: 2022-11-14 13:12:22.916848
""" """
@ -11,7 +11,7 @@ from alembic import context, op
# revision identifiers, used by Alembic. # revision identifiers, used by Alembic.
revision = '564952310b17' revision = '564952310b17'
down_revision = 'd65745749e34' down_revision = 'af038a8a388c'
branch_labels = None branch_labels = None
depends_on = None depends_on = None

5
ereuse_devicehub/resources/action/views/snapshot.py
View File

@ -8,7 +8,6 @@ from uuid import UUID
from flask import current_app as app from flask import current_app as app
from flask import g from flask import g
from marshmallow import ValidationError
from sqlalchemy.util import OrderedSet from sqlalchemy.util import OrderedSet
from ereuse_devicehub.db import db from ereuse_devicehub.db import db
@ -118,10 +117,6 @@ class SnapshotMixin:
snapshot.device.set_hid() snapshot.device.set_hid()
snapshot.device.binding.device.set_hid() snapshot.device.binding.device.set_hid()
if not snapshot.device.hid:
txt = "Not exist the basic fields for to do an device. "
txt += "Please do one placeholder instead of one snapshot"
raise ValidationError(txt)
return snapshot return snapshot

6
ereuse_devicehub/resources/device/schemas.py
View File

@ -213,9 +213,9 @@ class Computer(Device):
"""Validates than exist model manufacturer and system_uuid.""" """Validates than exist model manufacturer and system_uuid."""
minimum = [ minimum = [
data['manufacturer'], data.get('manufacturer'),
data['model'], data.get('model'),
data['system_uuid'], data.get('system_uuid'),
] ]
if not all(minimum): if not all(minimum):