From 9d7869929c578c5aeb7282da2fe0ce34fbab3e75 Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Tue, 25 Oct 2022 11:10:39 +0200
Subject: [PATCH] fix disks without placeholder

---
 ereuse_devicehub/inventory/views.py                    | 6 +++++-
 ereuse_devicehub/templates/inventory/erasure_list.html | 4 ++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ereuse_devicehub/inventory/views.py b/ereuse_devicehub/inventory/views.py
index 9682e0c1..567196eb 100644
--- a/ereuse_devicehub/inventory/views.py
+++ b/ereuse_devicehub/inventory/views.py
@@ -166,10 +166,14 @@ class DeviceDetailView(GenericMixin):
         )
 
         form_tags = TagDeviceForm(dhid=id)
+        placeholder = device.binding or device.placeholder
+        if not placeholder:
+            return NotFound()
+
         self.context.update(
             {
                 'device': device,
-                'placeholder': device.binding or device.placeholder,
+                'placeholder': placeholder,
                 'page_title': 'Device {}'.format(device.devicehub_id),
                 'form_tag_device': form_tags,
             }
diff --git a/ereuse_devicehub/templates/inventory/erasure_list.html b/ereuse_devicehub/templates/inventory/erasure_list.html
index 2d93d4bd..57f91b75 100644
--- a/ereuse_devicehub/templates/inventory/erasure_list.html
+++ b/ereuse_devicehub/templates/inventory/erasure_list.html
@@ -71,9 +71,13 @@
                                />
                       </td>
                       <td>
+                        {% if ac.device.phid() %}
                         <a href="{{ url_for('inventory.device_details', id=ac.device.dhid)}}">
                           {{ ac.device.serial_number.upper() }}
                         </a>
+                        {% else %}
+                        {{ ac.device.serial_number.upper() }}
+                        {% endif %}
                       </td>
                       <td>
                         <a href="{{ url_for('inventory.export', export_id='snapshot') }}?id={{ ac.snapshot.uuid }}">